MOD-8036 move AddACLCategory to redismodule-rs
#394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iddm
reviewed
Oct 31, 2024
src/macros.rs
Outdated
| acl_categories.as_ptr(), | ||
| ) | ||
| } == $crate::raw::Status::Err as c_int | ||
| if $crate::raw::RedisModule_SetCommandACLCategories.is_some() |
There was a problem hiding this comment.
Looks like a candidate of the if let some and else?
There was a problem hiding this comment.
sure. however that necessitates an if within an if as the resulting Some value will not be usable within the condition of the if it was generated from.
ephraimfeldblum
changed the title
AddACLCategory to redismodule-rsAddACLCategory to redismodule-rs
eranhd
approved these changes
Nov 3, 2024
eranhd
approved these changes
Nov 3, 2024
ephraimfeldblum
deleted the
ephraim_move-`AddACLCategory`-to-`redismodule-rs`
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.